checkout: dynamic height for picker - #469
Open
skarim wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the inline checkout picker to use available terminal height while remaining compact for smaller lists.
Changes:
- Dynamically sizes visible stack rows based on terminal height.
- Adds coverage for fallback, compact, expanded, search, and constrained layouts.
Show a summary per file
| File | Description |
|---|---|
internal/tui/checkoutview/model.go |
Implements dynamic picker height calculation. |
internal/tui/checkoutview/model_test.go |
Tests dynamic sizing and rendered height. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
skarim
force-pushed
the
skarim/checkout-tui-height
branch
from
August 25, 2026 01:36
66f9123 to
7688a13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the checkout picker to use the available terminal height when more than 10 stacks are available, instead of always capping the list at 10 rows.
The picker still stays compact for smaller result sets and preserves the existing spacing for search controls and inline rendering.
Stack created with GitHub Stacks CLI • Give Feedback 💬